Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies, hermetic build #429

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

dsseng
Copy link
Member

@dsseng dsseng commented Feb 13, 2025

  • Build Python dependencies hermetically
  • Download Go dependencies in prepare stage to ensure hermeticity
  • Fix ca-certificates permissions (fixes kres network issue)
  • Don't build sd-boot here, as we build systemd in pkgs
  • Publish packages to not be rebuilt in pkgs
  • Update toolchain for newer Go
  • Update dependencies
  • rekres

Fixes: #424
Ref: siderolabs/pkgs#1153

--- a/src/enabled.c
+++ b/src/enabled.c
@@ -13,11 +13,7 @@ int is_selinux_enabled(void)
/* init_selinuxmnt() gets called before this function. We
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this patch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do not create /etc/selinux/config

@dsseng dsseng force-pushed the bump-deps branch 2 times, most recently from 2fef503 to 524b452 Compare February 13, 2025 14:06
- Build Python dependencies hermetically
- Download Go dependencies in prepare stage to ensure hermeticity
- Fix ca-certificates permissions (fixes kres network issue)
- Don't build sd-boot here, as we build systemd in pkgs
- Publish packages to not be rebuilt in pkgs
- Update toolchain for newer Go
- Update dependencies
- rekres

Fixes: siderolabs#424
Ref: siderolabs/pkgs#1153
Signed-off-by: Dmitry Sharshakov <[email protected]>
python_sha256: 9cf9427bee9e2242e3877dd0f6b641c1853ca461f39d6503ce260a59c80bf0d9
python_sha512: 056c9b5fc0a6b540f41513d045f43c1ed463d15e0f345cecec703ec9c2335e53b4beb19de9c74ab2b236b023f934d5fd9ae7727a808634eaa01cfe66018a9a35
python_version: 3.13.2
python_maj_min_version: 3.13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could avoid this and use the go template to filter out the major minor

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would require separating multiple layers of vars.yaml 🤮

probably this way is cleaner

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frezbo I tried, but template doesn't work here, 2025/02/13 15:03:11 error parsing "Pkgfile": yaml: line 289: found unexpected end of stream

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we have to bump hashes by hand anyway

@dsseng
Copy link
Member Author

dsseng commented Feb 13, 2025

/m

@talos-bot talos-bot merged commit f398a04 into siderolabs:main Feb 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make python dependencies fixed by pinned version and hash
4 participants