Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: Add lsp integration test #1331

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

lsp: Add lsp integration test #1331

wants to merge 5 commits into from

Conversation

V-FEXrt
Copy link
Contributor

@V-FEXrt V-FEXrt commented Jun 29, 2023

This change adds a basic integration test to ensure that changing the LSP doesn't cause any serious regressions. It can be expanded on in the future but I wanted to get something out there

@V-FEXrt V-FEXrt requested a review from JakeSiFive June 29, 2023 20:18
Copy link
Contributor

@JakeSiFive JakeSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these high level functions look good, the only high level feedback I have is about putting stdin and reader into a struct.

rust/test-lsp-wake/src/main.rs Outdated Show resolved Hide resolved
rust/test-lsp-wake/src/main.rs Outdated Show resolved Hide resolved
rust/test-lsp-wake/test.wake Outdated Show resolved Hide resolved
Copy link
Collaborator

@ag-eitilt ag-eitilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good so far as I'm able to parse it.

Comment on lines +24 to +26
R: tower_lsp::lsp_types::request::Request,
R::Params: serde::Serialize,
R::Result: serde::de::DeserializeOwned,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suddenly have opinions about Rust type/namespace syntax...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants