-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lsp: Add lsp integration test #1331
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these high level functions look good, the only high level feedback I have is about putting stdin and reader into a struct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good so far as I'm able to parse it.
R: tower_lsp::lsp_types::request::Request, | ||
R::Params: serde::Serialize, | ||
R::Result: serde::de::DeserializeOwned, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suddenly have opinions about Rust type/namespace syntax...
This change adds a basic integration test to ensure that changing the LSP doesn't cause any serious regressions. It can be expanded on in the future but I wanted to get something out there