Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Fix bad PR race between #1362 and #1363 #1365

Merged
merged 2 commits into from
Jul 27, 2023
Merged

build: Fix bad PR race between #1362 and #1363 #1365

merged 2 commits into from
Jul 27, 2023

Conversation

V-FEXrt
Copy link
Contributor

@V-FEXrt V-FEXrt commented Jul 26, 2023

#1362 and #1363 were incompatible together but passed CI separately. This broke the build on master, this change fixes the build.

@V-FEXrt V-FEXrt requested a review from JakeSiFive July 26, 2023 23:28
@V-FEXrt V-FEXrt changed the title Fix bad PR race build: Fix bad PR race between #1362 and #1363 Jul 26, 2023
@V-FEXrt V-FEXrt requested a review from mmjconolly July 26, 2023 23:29
JakeSiFive
JakeSiFive approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@JakeSiFive JakeSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good, thanks for figuring out that it was a PR race!

@V-FEXrt V-FEXrt merged commit f5ebab8 into master Jul 27, 2023
13 checks passed
@V-FEXrt V-FEXrt deleted the wake-build-fix branch July 27, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeSiFive JakeSiFive JakeSiFive approved these changes

@mmjconolly mmjconolly Awaiting requested review from mmjconolly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@V-FEXrt @JakeSiFive