Fix unused warnings #1366
Merged
Fix unused warnings #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V-FEXrt
approved these changes
Jul 27, 2023
JakeSiFive
force-pushed
the
fix_unused_warnings
branch
from
6d5e624
to
cf63963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intentionally added un-checked writes to the system. These occur in single threaded instances where we can't block until they succeed, and we don't want to fail the whole system just because they fail, additionally if the log fails we can't log that fact because this is the logger and it would create a logger loop if we created an event that we also processed. We could add a tag to it to tell the json subscriber specifically to not process that event but it just gets complicated. So instead we just do the write (which should be a single atomic append) and we move on.