Rewrite match = as -> inside of match
#1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ag-eitilt
reviewed
Sep 8, 2023
| @@ -1591,15 +1591,13 @@ wcl::doc Emitter::walk_flag_global(ctx_t ctx, CSTElement node) { | |||
|
|
|||
| wcl::doc Emitter::walk_guard(ctx_t ctx, CSTElement node) { | |||
| MEMO(ctx, node); | |||
| MEMO_RET(walk_placeholder(ctx, node)); | |||
There was a problem hiding this comment.
I assume walk_placeholder is used elsewhere and so doesn't become dead code?
There was a problem hiding this comment.
yeah, its the main fallback function
tests/tests.wake
Outdated
There was a problem hiding this comment.
This file is the only one which seems to be related to testing -- don't the unit/golden tests have to be updated to reflect this as well?
There was a problem hiding this comment.
they do, I missed them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
wake-formatrule to always emit->as the match case separator which shows the correct data flow direction.