Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlib: Significantly refactor the Runner api #1640

Merged
merged 15 commits into from
Sep 9, 2024
Merged

Conversation

V-FEXrt
Copy link
Contributor

@V-FEXrt V-FEXrt commented Aug 30, 2024

I'll edit this later with a longer description but wanted to kick of ci.

tl;dr:

  • breaking change
  • score is gone
  • makeRunner -> depreMakeRunner
  • new makeRunner takes a single run function instead of two split functions with convoluted apis

Copy link
Collaborator

@ag-eitilt ag-eitilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI and general integration are happy, I greatly prefer this architecture. Everything looks good at a first pass, but there's enough moved blocks of code that I'm going to have to use other methods of reading the diff to fully see what it's changed (the by-commit reading you mentioned, undoing indentation changes for better diffs, ...) so I don't want to click approve immediately -- let me know if you want to get this in sooner than I get around to looking at it at that level of detail, I don't expect to find anything unpleasantly surprising.

share/wake/lib/system/io.wake Outdated Show resolved Hide resolved
share/wake/lib/system/job.wake Outdated Show resolved Hide resolved
share/wake/lib/system/remote_cache_runner.wake Outdated Show resolved Hide resolved
share/wake/lib/system/runner.wake Outdated Show resolved Hide resolved
share/wake/lib/system/runner.wake Outdated Show resolved Hide resolved
share/wake/lib/system/runner.wake Outdated Show resolved Hide resolved
Copy link
Collaborator

@ag-eitilt ag-eitilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that all looks good even after a deeper readthrough.

share/wake/lib/system/runner.wake Show resolved Hide resolved
share/wake/lib/system/runner.wake Outdated Show resolved Hide resolved
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean refactor to me. All the runners look simpler and we can finally drop the score tech debt.

A couple of non-blocking comments/questions and things that we should keep in mind as we continue some of this refactor work.

share/wake/lib/system/io.wake Outdated Show resolved Hide resolved
share/wake/lib/system/io.wake Outdated Show resolved Hide resolved
share/wake/lib/system/io.wake Outdated Show resolved Hide resolved
share/wake/lib/system/io.wake Show resolved Hide resolved
share/wake/lib/system/io.wake Show resolved Hide resolved
share/wake/lib/system/io.wake Show resolved Hide resolved
share/wake/lib/system/job.wake Show resolved Hide resolved
share/wake/lib/system/job.wake Show resolved Hide resolved
share/wake/lib/system/job_cache_runner.wake Outdated Show resolved Hide resolved
@V-FEXrt V-FEXrt merged commit 82da532 into master Sep 9, 2024
11 checks passed
@V-FEXrt V-FEXrt deleted the stdlib-runner-refactor branch September 9, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants