-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdlib: Significantly refactor the Runner api #1640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming CI and general integration are happy, I greatly prefer this architecture. Everything looks good at a first pass, but there's enough moved blocks of code that I'm going to have to use other methods of reading the diff to fully see what it's changed (the by-commit reading you mentioned, undoing indentation changes for better diffs, ...) so I don't want to click approve immediately -- let me know if you want to get this in sooner than I get around to looking at it at that level of detail, I don't expect to find anything unpleasantly surprising.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that all looks good even after a deeper readthrough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a clean refactor to me. All the runners look simpler and we can finally drop the score tech debt.
A couple of non-blocking comments/questions and things that we should keep in mind as we continue some of this refactor work.
Co-authored-by: Colin Schmidt <[email protected]>
I'll edit this later with a longer description but wanted to kick of ci.
tl;dr: