rsc: Disallow hidden file dependencies #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V-FEXrt
force-pushed
the
rsc-disallowed-hidden-file
branch
from
e6e6e15
to
f56a6d5
Compare
V-FEXrt
changed the title
| symlinksUpload | ||
| | findFail | ||
| |< map getCachePostRequestOutputSymlinkPath | ||
| else True |
There was a problem hiding this comment.
If we are unable to get the target for an output symlink, we are assuming that means this job didn't output it?
Or are we just choosing to ignore that error here and let some other part of the code handle that failure.
There was a problem hiding this comment.
we just choosing to ignore that error here and let some other part of the code handle that failure
This one. The only failure here is a failure to readlink and if that fails then another part of the code (just a few lines below) will fully abort the job push
Co-authored-by: Colin Schmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a job creates both a file and a symlink to that file but only outputs the symlink it creates a hidden dependency on that untracked file.
This is generally not a huge problem but now is since the RSC is moving to only track true dependencies. The symlink would be restored but not the "hidden" file.
This PR panics when that situation occurs for a cached job. Broken jobs can avoid this by opting out of caching or by also outputting the hidden file