rsc: Track hidden output dirs #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinschmidt
approved these changes
Sep 23, 2024
| | addErrorContext "rsc: Failed to stat files to upload" | ||
| def filteredOutputs = output.getRunnerOutputOutputs | ||
| def cleanableOutputs = output.getRunnerOutputCleanableOutputs | ||
| def hiddenOutputs = subtract scmp cleanableOutputs filteredOutputs |
There was a problem hiding this comment.
Should we do this subtract after the grouping so one of the lists is smaller?
There was a problem hiding this comment.
I don't think that helps, we have to stat the full union of filteredOutputs and cleanableOutputs in order to determine which are symlinks and I think that will be the majority of the time spent in the function (fwiw we were always stating the full list so it shouldn't be a time regression)
V-FEXrt
force-pushed
the
rsc-track-hidden-dirs
branch
from
7a18d17
to
9ce6cf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the RSC and clients to track "hidden" directories which are directories created by a job but not output by the job.
This is necessary as some jobs will output a file and depends on the directory being created without also outputting said directory