fill color customization #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitMY
requested changes
Apr 9, 2024
| line_color=(144, 70, 180, 255), embedded_color=True) | ||
| fsw = "M530x518S19a30500x482S19a38465x481S22f04509x506S22f14467x504" | ||
| image = signwriting_to_image(fsw, line_color=( | ||
| 10, 23, 122, 255), fill_color=(255, 255, 255, 0)) |
There was a problem hiding this comment.
i don't like where the line breaks - either new line before line_color or same line with the color
signwriting/visualizer/visualize.py
Outdated
| line_color: tuple[int, int , int, int]=(0, 0, 0, 255), embedded_color=False) -> Image: | ||
| # pylint: disable=too-many-locals, too-many-arguments | ||
| def signwriting_to_image(fsw: str, antialiasing=True, trust_box=True, embedded_color=False, | ||
| line_color: Tuple[int, int, int, int] = (0, 0, 0, 255), |
There was a problem hiding this comment.
perhaps it is worth, for readability:
type RGBA = Tuple[int, int, int, int]
signwriting/visualizer/visualize.py
Outdated
| @@ -53,7 +55,7 @@ def signwriting_to_image(fsw: str, antialiasing=True, trust_box=True, | |||
| x, y = symbol["position"] | |||
| x, y = x - min_x, y - min_y | |||
| symbol_id = key2id(symbol["symbol"]) | |||
| draw.text((x, y), symbol_fill(symbol_id), (255, 255, 255, 255), fill_font) | |||
| draw.text((x, y), symbol_fill(symbol_id), fill_color, fill_font, embedded_color=embedded_color) | |||
There was a problem hiding this comment.
can we name these variables? fill=fill_color, font=fill_font
| @@ -55,10 +54,9 @@ def test_image_small_box_is_corrected(self): | |||
| assert_array_equal(np.array(image), np.array(reference_image)) | |||
|
|
|||
| def test_image_with_line_and_embedded_color(self): | |||
There was a problem hiding this comment.
this test is now problematic as it tests too many things at once: line color, and transparent fill.
the name suggests it tests embedded_color but it doesn't
needs at least three tests:
- embedded_color
- line_color
- fill_color
- ideally, line and fill
- ideally, line and embedded
|
Its done. |
AmitMY
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.