Skip to content

Commit

Permalink
[Mac] Set a valid interface number on hid_device_info for USB HID dev…
Browse files Browse the repository at this point in the history
…ices

Previously the interface would never be set on Mac.

This presents a big pain because retrieving interface numbers can be the
only way to distinguish between the interfaces returned by HIDAPI.

This change makes it possible to retrieve interface number from an
hid_device_info on Mac for USB HID devices only.

It is unclear if the Mac OS IOKit library returns valid interface numbers for non-HID USB devices. Because of this, I have opted to simply skip that case - leave it initialised to `-1`.

In the future, we can easily relax this restriction if it turns out IOKit correctly returns interface number with non-HID USB devices. For now, this PR brings 90% of the value at 5% of the risk.
  • Loading branch information
dylanmckay committed Nov 21, 2018
1 parent c283c71 commit 2357fb5
Showing 1 changed file with 0 additions and 0 deletions.
Empty file added a
Empty file.

0 comments on commit 2357fb5

Please sign in to comment.