Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac: fix behaviour of hid_get_feature_report #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mac: fix behaviour of hid_get_feature_report #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mac/hid.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,7 +948,7 @@ int HID_API_EXPORT hid_send_feature_report(hid_device *dev, const unsigned char

int HID_API_EXPORT hid_get_feature_report(hid_device *dev, unsigned char *data, size_t length)
{
CFIndex len = length;
CFIndex len = length - 1;
IOReturn res;

/* Return if the device has been unplugged. */
Expand All @@ -958,9 +958,9 @@ int HID_API_EXPORT hid_get_feature_report(hid_device *dev, unsigned char *data,
res = IOHIDDeviceGetReport(dev->device_handle,
kIOHIDReportTypeFeature,
data[0], /* Report ID */
data, &len);
data + 1, &len);
if (res == kIOReturnSuccess)
return len;
return len + 1;
else
return -1;
}
Expand Down