Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability changes #398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Usability changes #398

wants to merge 1 commit into from

Conversation

zhumxcq
Copy link

@zhumxcq zhumxcq commented Jun 26, 2018

Vendor and product ID equals to 0 means match on any.
Reduced buffer size from 64 to 2 because 64 buffers delays the input significantly.

@@ -576,7 +576,7 @@ HID_API_EXPORT hid_device * HID_API_CALL hid_open_path(const char *path)
}

/* Set the Input Report buffer size to 64 reports. */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should also change, no?

Copy link

@jonathancross jonathancross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you believe this change is appropriate for all projects using hidapi, please consider making this PR also at https://github.com/libusb/hidapi

See #373

erikolofsson pushed a commit to Malterlib/hidapi that referenced this pull request May 14, 2022
- add convenient macros to check HIDAPI version in runtime;
- mark in which version all recent HIAPI API functions where added;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants