Skip to content

Commit

Permalink
Resolve some gradle 8 deprecations.
Browse files Browse the repository at this point in the history
Resolves #13788
  • Loading branch information
jamesonwilliams authored and greyson-signal committed Nov 21, 2024
1 parent d5a2e13 commit 3eb1f68
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 13 deletions.
6 changes: 4 additions & 2 deletions benchmark/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ dependencies {

androidComponents {
beforeVariants(selector().all()) {
it.enabled = it.buildType == "benchmark"
if (it.buildType != "benchmark") {
it.enable = false
}
}
}
}
6 changes: 4 additions & 2 deletions build-logic/plugins/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@ java {
targetCompatibility = signalJavaVersion
}

kotlinDslPluginOptions {
jvmTarget.set(signalKotlinJvmTarget)
kotlin {
jvmToolchain {
languageVersion.set(JavaLanguageVersion.of(signalKotlinJvmTarget))
}
}

dependencies {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ android {

defaultConfig {
minSdk = signalMinSdkVersion
targetSdk = signalTargetSdkVersion
}

compileOptions {
Expand Down
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ tasks.register("qa") {
}

tasks.register("clean", Delete::class) {
delete(rootProject.buildDir)
delete(rootProject.layout.buildDirectory)
}

tasks.register("format") {
Expand Down
2 changes: 0 additions & 2 deletions microbenchmark/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ android {

defaultConfig {
minSdk = signalMinSdkVersion
targetSdk = signalTargetSdkVersion

testInstrumentationRunner = "androidx.benchmark.junit4.AndroidBenchmarkRunner"
}

Expand Down
5 changes: 0 additions & 5 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ dependencyResolutionManagement {
maven {
url = uri("https://dl.cloudsmith.io/qxAgwaeEE1vN8aLU/mobilecoin/mobilecoin/maven/")
}
jcenter {
content {
includeVersion("mobi.upod", "time-duration-picker", "1.1.3")
}
}
}
}

Expand Down

0 comments on commit 3eb1f68

Please sign in to comment.