Fixes #13936 - Finish StoryActivity if Story was already deleted #13938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+160
to
+162
| private fun finish() { | ||
| requireActivity().finish() | ||
| } |
There was a problem hiding this comment.
I don't think we need a function for this, calling requireActivity().finish() directly is fine
| @@ -116,6 +118,11 @@ class StoryViewerFragment : | |||
| requireActivity().supportStartPostponedEnterTransition() | |||
| } | |||
|
|
|||
| if (state.crossfadeTarget is StoryViewerState.CrossfadeTarget.None) { | |||
| toast(R.string.ConversationFragment_quoted_message_not_found) | |||
There was a problem hiding this comment.
This function moves the toast to the main thread, implying that there's a concern this isn't running on the main thread already. There's lot of other view stuff happening in this function, are we sure it's not running on the main thread?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13936
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription
Fixes:
Closes the StoryActivty if onQuoteClick has a deleted message's ID.
Improvements:
Start this StoryActivity for result, and if the result from StoryViewerFragment says that the story message is deleted, then after receiving that result in ChaFragment, update that paticular message's state.
Should I use onActivityResult? or launcher?
Is it fine to update the message state from this callback?
Add a callback listening to deletion of story.