Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect member count during group creation and modification #14011

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cale146
Copy link

@Cale146 Cale146 commented Feb 23, 2025

Resolves issue #13206 where the member count displayed was inaccurate when creating or modifying groups. The member count now reflects the correct number of participants when selecting/deselecting.

First time contributor checklist

Contributor checklist

  • Motorola Moto G Power 5G, API 34
  • Virtual Device Pixel 9 Pro, API 35
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #13206 syntax

Description

Previously, the displayed member count in the 'X members' message was incorrect when adding/removing members from both new and existing groups. This PR ensures the correct count is shown at all times.

Resolves issue signalapp#13206 where the member count displayed was inaccurate when creating or modifying groups.  The member count now reflects the correct number of participants when selecting/deselecting.
Copy link
Contributor

@greyson-signal greyson-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This will go into 7.36

@Cale146
Copy link
Author

Cale146 commented Feb 24, 2025

Thanks @greyson-signal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants