Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent empty passphrases when restoring local chat backups #14016

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eyedol
Copy link
Contributor

@eyedol eyedol commented Feb 25, 2025

First time contributor checklist

Contributor checklist

  • Pixel 8 Pro, Android 15
  • Virtual device W, Android Y.Y.Z
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Introduces PassphraseDialogManager to handle the display and input of the backup passphrase dialog. This centralizes the passphrase dialog logic, improves code organization, and allows for easier management of error states and input validation. Updates RestoreLocalBackupFragment to use the new PassphraseDialogManager. Enables the dialog positive button only when input is not blank. Shows error on the text input when a blank passphrase is entered.

Before After

…l chat backups

Introduces `PassphraseDialogManager` to handle the display and input of the backup passphrase dialog. This centralizes the passphrase dialog logic, improves code organization, and allows for easier management of error states and input validation. Updates `RestoreLocalBackupFragment` to use the new `PassphraseDialogManager`. Enables the dialog positive button only when input is not blank.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant