configurable log level via SIGNALFX_LOGLEVEL #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
as the title says, this change adds support for a configurable log level via a
SIGNALFX_LOGLEVEL
environment variable.while using the
sfx-sync-detectors
utility to validate detectors, useful context from thehttps://api.signalfx.com/v2/detector/validate
API is lost in translation. for example:with this change and an
export SIGNALFX_LOGLEVEL=debug
, the debug logs contain the message returned from the API:i'm sure there are other ways to accomplish this, but this 2 line change did the trick for me and doesn't change any existing behavior unless the environment variable is set. i imagine it might be useful in other cases beyond just the one i found myself stumbling over today as well.
thanks in advance for taking a look.