Skip to content

Commit

Permalink
patch
Browse files Browse the repository at this point in the history
  • Loading branch information
jvoravong committed Dec 12, 2024
1 parent 154711e commit 0fc04bf
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 11 deletions.
10 changes: 3 additions & 7 deletions .chloggen/refactor-agent-daemonset-toleration.yaml
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking
change_type: enhancement
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
component: agent
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Make it so the default tolerations used to deploy the agent collector account for k8s distribution
# One or more tracking issues related to the change
issues: [1562,1572]
issues: [1562]
# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: |
The agent collector now adjusts default tolerations based on Kubernetes distributions.
OpenShift infra nodes and AKS system nodes are included in default monitoring.
Default tolerations are applied when `tolerations: []` is set, instead of being explicitly defined in `values.yaml`.
To disable default tolerations (previously settable using the value `tolerations: []`), now only use the values `tolerations:` or `tolerations: null`.
subtext: OpenShift infra nodes and AKS system nodes will now be monitored by the agent by default
2 changes: 1 addition & 1 deletion helm-charts/splunk-otel-collector/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1192,7 +1192,7 @@
}
},
"tolerations": {
"type": ["array", "null"],
"type": "array",
"items": {
"type": "object"
}
Expand Down
3 changes: 0 additions & 3 deletions helm-charts/splunk-otel-collector/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1011,7 +1011,6 @@ secret:

# The tolerations for deploying the agent collector daemonset. By default, it targets control-plane, worker,
# and k8s distribution-specific nodes (infrastructure or system) to ensure logs and metrics collection from nodes.
# If set, the specified tolerations will override the defaults.
tolerations:
- key: node-role.kubernetes.io/master
effect: NoSchedule
Expand All @@ -1025,8 +1024,6 @@ tolerations:
- key: node-role.kubernetes.io/infra
effect: NoSchedule
operator: Exists
# Defines which nodes should be selected to deploy the o11y collector daemonset.


# Defines which nodes should be selected to deploy the agent collector daemonset.
nodeSelector: {}
Expand Down

0 comments on commit 0fc04bf

Please sign in to comment.