Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update collector version to v0.88.0 #1019

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Update collector version to v0.88.0 #1019

merged 2 commits into from
Nov 22, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Use the new version of the collector

@github-actions github-actions bot requested review from a team as code owners November 17, 2023 01:00
@jvoravong jvoravong closed this Nov 17, 2023
@jvoravong jvoravong reopened this Nov 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
@jvoravong jvoravong closed this Nov 17, 2023
@jvoravong jvoravong reopened this Nov 17, 2023
@atoulme atoulme closed this Nov 21, 2023
@atoulme atoulme reopened this Nov 21, 2023
@jinja2 jinja2 marked this pull request as draft November 22, 2023 00:26
@jinja2
Copy link
Collaborator

jinja2 commented Nov 22, 2023

The tests are failing with 0.88 due to use of a removed config max_connections in splunk_hec exporter

@atoulme
Copy link
Contributor

atoulme commented Nov 22, 2023

I propose to use max_idle_conns_per_host to replace max_connections, per deprecation guidelines. https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/27611/files

@atoulme atoulme closed this Nov 22, 2023
@atoulme atoulme reopened this Nov 22, 2023
@jinja2 jinja2 closed this Nov 22, 2023
@jinja2 jinja2 reopened this Nov 22, 2023
@jinja2 jinja2 marked this pull request as ready for review November 22, 2023 20:39
@jinja2 jinja2 merged commit 33fe77c into main Nov 22, 2023
26 checks passed
@jinja2 jinja2 deleted the update-v0.88.0 branch November 22, 2023 20:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atoulme atoulme atoulme approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@jinja2 jinja2 jinja2 approved these changes

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jinja2 @atoulme @crobert-1 @jvoravong