Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Delete log correctness tests #1020

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Nov 17, 2023

Delete 3 tests partially covered by new tests:

  • Two tests that cover the toggle to collect collector logs as part of logs collected.
  • One test that check persistent storage.

I think we have enough coverage with our other tests and samples. We could potentially turn those tests into unit tests checking the yaml we generate is correct based on those arguments.

@atoulme atoulme requested review from a team as code owners November 17, 2023 01:22
@atoulme atoulme merged commit 79312ca into main Dec 1, 2023
25 checks passed
@atoulme atoulme deleted the delete_log_correctness_tests branch December 1, 2023 22:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants