-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the clusterName value optional in EKS and GKE #1056
Conversation
46422e5
to
a594e61
Compare
To get the EKS functional-tests up and running, you will have to close this PR and open up a different PR in a specific way due to recent project test updates. The EKS functional tests need to run with credentials that are only available in this repo.
|
These changes LGTM. A couple small nits. Will approve a separate PR that has the EKS functional tests passing. |
Indeed, please push to this repository and open a PR rather than from your fork. |
Co-authored-by: jvoravong <[email protected]>
Co-authored-by: jvoravong <[email protected]>
Closing in favor of #1067 |
Description:
Now that the resource detection processor supports detecting the
k8s.cluster.name
in GKE and EKS environments, theclusterName
value can be optional in these environments.A simplified resource detection processor has been added to more pipelines in this change as well, in every place the
clusterName
was manually being added.Testing:
Tested in GKE and kOps. GKE sets cluster name properly without it specified, and overrides the detected
k8s.cluster.name
whenclusterName
is set. kOps fails withoutclusterName
with the following message:The
- (root)
lines are a bit confusing, but that's simply saying that the check failed, AFAICT.Documentation:
Updated README and relevant comments in code.