-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring after #1481 - removing not needed env variables #1540
Open
pszkamruk-splunk
wants to merge
35
commits into
signalfx:main
Choose a base branch
from
pszkamruk-splunk:removing-not-needed-env-variables
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactoring after #1481 - removing not needed env variables #1540
pszkamruk-splunk
wants to merge
35
commits into
signalfx:main
from
pszkamruk-splunk:removing-not-needed-env-variables
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For resource/add_collector_k8s:
Functional Tests cover internal collector metrics and attributes (e.g., otelcol_exporter_send_failed_spans).
|
…dex from annotation
… all logs pipelines
sorry, please fix conflicts |
pszkamruk-splunk
changed the title
Refactoring after #1481 - removing not needed env variables
[WiP] Refactoring after #1481 - removing not needed env variables
Dec 12, 2024
…dex from annotation � Conflicts: � helm-charts/splunk-otel-collector/templates/config/_common.tpl
pszkamruk-splunk
force-pushed
the
removing-not-needed-env-variables
branch
from
December 12, 2024 16:00
556fad6
to
88f9bf8
Compare
…on' into removing-not-needed-env-variables
…moving-env-variables
…moving-env-variables
…-not-needed-env-variables
Regarding work done here:
Once this PR will be merged, next steps are:
PS: Let's merge first #1610 as I pulled it into this PR, then I will rebase and squash and we can merge this one. |
pszkamruk-splunk
changed the title
[WiP] Refactoring after #1481 - removing not needed env variables
Refactoring after #1481 - removing not needed env variables
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cleanup and refactor work to prevent code duplication related to setting Kubernetes attributes by using k8sAttributesProcessor for cluster receiver introduced by PR
Once following two PRs will be merged we can merge this one:
We need also decide what to do with
resource/add_collector_k8s
: linkas this is using env variables which we want to remove, but the functionality of adding additional parameters is covered by
k8sattributes/metrics
, so probably it is safe to removeresource/add_collector_k8s
from configuration