test upgrade with no change in values

[jinja2]

Description:

Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>

Testing:

Documentation:

[atoulme]

The chart fails to upgrade:

Error: UPGRADE FAILED: Unable to continue with update: Instrumentation "sock-splunk-otel-collector" in namespace "default" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "sock"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "default"

[jinja2]

So upgrade fails due to this change introduced in latest which makes instrumentation a non-hook object. On upgrade helm sees the object exists but it is not part of tracked objects in its release, hence the error about missing annotations "meta.helm.sh/*"

[jinja2]

required cmds to get around the instrumentation hook to non-hook change on upgrade

[jinja2]

I think I have tried all combinations of possible ways an existing user with operator enabled could try to helm upgrade. The only option which seems to work where upgrade does not fail and the crds are kept is where they explicitly add the var operator.crds.create=true and some fix for the instrumentation object. For the latter, let me see if i can conditionally introduce the hook annotations back if crds.create is true and that solves the issue for new installs with subchart and existing operator templates.