Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build system #197

Merged
merged 33 commits into from
Jul 23, 2021
Merged

Build system #197

merged 33 commits into from
Jul 23, 2021

Conversation

framini
Copy link
Contributor

@framini framini commented Jul 20, 2021 •
edited
Loading

Tasks

  • Create CLI for abstracting building with esbuild
  • Migrate packages to use the new CLI tool
  • Generate UMD for js package
  • Update engines in node/package.json to use Node 12+
  • Audit all package.json to see we are not defining unneeded fields
  • Remove microbundle and related things (patches and pkg-typings)

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: b07e979

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

edolix and others added 16 commits July 20, 2021 19:08
@edolix
fix type checking on core
2720e81
@edolix
use tsc to compile webrtc pkg
12749d7
@edolix
add jest testMatch on webrtc
81fe1a7
@edolix
add esbuild on node and tsc for types
f365ddd
@edolix
update webrtc package.json fields
c9c55b7
@framini
Merge pull request #198 from signalwire/eg/esbuild-types
3110a92 
Using tsc for webrtc, add esbuild for node and others
@framini
create cli for building and developing packages using esbuild
cd5f4df
@framini
update core to use new cli
b5fb69a
@framini
remove unused var
f687225
@framini
improve loggers when the build is successful or failed
4a0ea45
@framini
update js package to use the new cli
9efd3da
@framini
extend cli to support multiple different outputs and selective watch …
6b0c757 
…mode
@framini
back to defaults on nodeExternalsPlugin to avoid bundling deps, add todo
d7000de
@framini
move node to the new cli
3cfa435
@framini
extend cli to show which mode was built
52e9f31
@framini
cleanup files
b7ddee2
@framini framini changed the title WIP: Replace microbundle with esbuild WIP: Build system Jul 21, 2021
@framini framini requested a review from edolix July 21, 2021 10:41
edolix
edolix reviewed Jul 22, 2021
View reviewed changes
packages/js/package.json Show resolved Hide resolved
packages/node/tsconfig.build.json Outdated Show resolved Hide resolved
scripts/sw-build/index.js Outdated Show resolved Hide resolved
@framini framini changed the title WIP: Build system Build system Jul 22, 2021
@edolix edolix mentioned this pull request Jul 22, 2021
Closed
edolix
edolix reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@edolix edolix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed some commits to update the lock file (after clean install) and also exclude tests files in tsconfigs.

And as already said... esbuild is AMAZING!

scripts/sw-build/index.js Outdated
// what to bundle and what not
plugins: [nodeExternalsPlugin()],
}
// TODO: review options for --node and --web
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for TODO

scripts/sw-build/index.js Show resolved Hide resolved
edolix
edolix approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@edolix edolix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edolix edolix merged commit 7ea9522 into canary Jul 23, 2021
@edolix edolix deleted the fr/esbuild branch July 23, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolix edolix edolix approved these changes

Assignees
No one assigned
Labels
type/epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@framini @edolix