Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: openai_compatible client config #820

Merged
merged 1 commit into from
Sep 1, 2024
Merged

refactor: openai_compatible client config #820

merged 1 commit into from
Sep 1, 2024

Conversation

sigoden
Copy link
Owner

@sigoden sigoden commented Sep 1, 2024

Remove chat_endpoint and embeddings_endpoint fields.

The APIs I've seen that are OpenAI-compatible all have consistent endpoints. These two fields are meaningless.

In case of special circumstances, it can also be resolved through the patch mechanism.

    patch:
      chat_completions:
        '.*':
          url: <endpoint>

remove `chat_endpoint` and `embeddings_endpoint` fields
@sigoden sigoden merged commit 2c6aafb into main Sep 1, 2024
3 checks passed
@sigoden sigoden deleted the refactor branch September 1, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant