feat: better html to markdown converter #840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used the
html2text
crate, but now we have switched tohtml_to_markdown
crate.Here is the reason:
html2text::from_read(html, wrap_width)
requires a wrap_width, but for RAG, a larger wrap width is better. However, usingusize::MAX
can cause issues, as it may result in the generated markdown file being excessively large due tohtml2text
automatically inserting spaces forwrap_width
.html_to_markdown::convert_html_to_markdown
allows us to control how each type of element is converted. For example, ignore<img>
,<video>
tags.