Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep execution payload during historical backfill when prune-payloads set to false #6766

Open
wants to merge 13 commits into
base: unstable
Choose a base branch
from

Conversation

chong-he
Copy link
Member

@chong-he chong-he commented Jan 8, 2025

Issue Addressed

Proposed Changes

  • Keep execution payload during historical backfill when --prune-payloads false is set
  • Add a field in the historical backfill debug log to indicate if execution payload is kept
  • Add a test to check historical blocks has execution payload when `--prune-payloads false is set
  • Very minor typo correction that I notice when working on this

Additional Info

  • I have done manual testing that when the flag is set to false, we see that the number of keys returned:
    lighthouse db inspect --column exp --output sizes --datadir path is around the range of: head_slot - oldest_block_slot, so I think it works

Thank you @michaelsproul for the hints in testing

@chong-he chong-he added the work-in-progress PR is a work-in-progress label Jan 8, 2025
@chong-he chong-he changed the title Keep execution payload Keep execution payload during historical backfill when prune-payloads set to false Jan 8, 2025
@chong-he chong-he requested a review from jxs as a code owner January 15, 2025 01:27
@chong-he chong-he added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants