Add block ban flag --invalid-block-roots
#7042
Open
+107
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2025
Closed
michaelsproul
force-pushed
the
block-ban-flag
branch
from
6f2b7ef to
f5b4e4a
Compare
|
I've cherry-picked all the block ban related changes to this PR and rebased on |
|
I reverted the |
michaelsproul
changed the title
--invalid-block-roots
dapplion
reviewed
Feb 26, 2025
| ParentExecutionPayloadInvalid { | ||
| parent_root: Hash256, | ||
| }, | ||
| KnownInvalidExecutionPayload(Hash256), |
There was a problem hiding this comment.
Add comment on top of this variant to have same format
dapplion
reviewed
Feb 26, 2025
| @@ -1326,6 +1343,19 @@ impl<T: BeaconChainTypes> ExecutionPendingBlock<T> { | |||
| chain: &Arc<BeaconChain<T>>, | |||
| notify_execution_layer: NotifyExecutionLayer, | |||
| ) -> Result<Self, BlockError> { | |||
| let invalid_holesky_block = { | |||
| if let Ok(invalid_block_root) = Hash256::from_str( | |||
| "2db899881ed8546476d0b92c6aa9110bea9a4cd0dbeb5519eb0ea69575f1f359", | |||
There was a problem hiding this comment.
Is it intentional to hardcode a block here? You can add this block root in the default value of the CLI flag invalid_block_roots
dapplion
reviewed
Feb 26, 2025
| false | ||
| } | ||
| }; | ||
| if chain.config.invalid_block_roots.contains(&block_root) || invalid_holesky_block { |
There was a problem hiding this comment.
This flag can be exploited for censoring, you should restrict usage to a specific network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new flag that allows users to ban block roots listed in a file. Also make sure the hardcoded invalid block root is only considered on holesky