Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --disable-attesting flag to validator client #7046

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

michaelsproul
Copy link
Member

Proposed Changes

Cleaned up and isolated version of the --disable-attesting flag for the VC, from the holesky-rescue branch:

I figured we don't need the --disable-attesting flag on the BN for now, and it was a much more invasive impl.

@michaelsproul michaelsproul added val-client Relates to the validator client binary ready-for-review The code is ready for review v7.0.0-beta.2 labels Feb 26, 2025
@michaelsproul michaelsproul mentioned this pull request Feb 26, 2025
6 tasks
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, moving it to the VC makes sense - also avoids clogging the beacon processor on P0 requests.

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 26, 2025
mergify bot added a commit that referenced this pull request Feb 26, 2025
@mergify mergify bot merged commit 80cd8bd into sigp:release-v7.0.0 Feb 26, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v7.0.0-beta.2 val-client Relates to the validator client binary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants