chore: relax go directive to permit 1.22.x #927
Conversation
Similar to sigstore/rekor#2323, relax the go.mod go directive to 1.22.0 here as well. The go directive sets the minimum version of Go required to use this module. There's no need to set this to the latest semver patch version of a given Go release unless the semantics of that version of Go are required to build/test/use the module. Ref: https://go.dev/ref/mod#go-mod-file-go Signed-off-by: Dominic Evans <[email protected]>
| @@ -37,7 +39,7 @@ require ( | |||
| golang.org/x/net v0.34.0 | |||
| google.golang.org/protobuf v1.36.3 | |||
| gopkg.in/yaml.v3 v3.0.1 | |||
| sigs.k8s.io/release-utils v0.9.0 | |||
| sigs.k8s.io/release-utils v0.8.4 | |||
There was a problem hiding this comment.
fyi @cpanato since you maintain this - I looked into why release-utils had to bump to 1.23 and the culprit seems to be https://github.com/maxbrunsfeld/counterfeiter/, which I think could be trivially downgraded back to 1.22.
There was a problem hiding this comment.
@haydentherapper i saw this one, but an issue had already been raised and the maintainer didn’t seem keen to cut a new release before 1.24, see here
There was a problem hiding this comment.
More specifically, 1.23 type aliasing had been introduced into the code so a trivial downgrade wasn’t possible
There was a problem hiding this comment.
ok, I was nerdsniped into making a PR for counterfeiter here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #927 +/- ##
==========================================
- Coverage 52.85% 44.73% -8.12%
==========================================
Files 20 55 +35
Lines 1209 3657 +2448
==========================================
+ Hits 639 1636 +997
- Misses 509 1881 +1372
- Partials 61 140 +79 ☔ View full report in Codecov by Sentry. |
Summary
Similar to sigstore/rekor#2323, relax the go.mod go directive to 1.22.0 here as well.
The go directive sets the minimum version of Go required to use this module. There's no need to set this to the latest semver patch version of a given Go release unless the semantics of that version of Go are required to build/test/use the module.
Ref: https://go.dev/ref/mod#go-mod-file-go
Release Note
NONE
Documentation
NONE