Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise wording in "authInit failed" error log message #345

Merged
merged 1 commit into from
May 20, 2024
Merged

Revise wording in "authInit failed" error log message #345

merged 1 commit into from
May 20, 2024

Conversation

forevermatt
Copy link
Contributor

Changed (non-breaking)

  • Revise wording in "authInit failed" error log message

Feature PR Checklist

  • Documentation (README, local.env.dist, etc.)
  • Unit tests created or updated
  • Run make composershow
  • Run make psr2

@forevermatt forevermatt requested review from briskt and a team May 16, 2024 15:30
@forevermatt forevermatt mentioned this pull request May 16, 2024
Merged
briskt
briskt approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry you had to create a new feature branch for this. I could have left it alone.

@forevermatt
Copy link
Contributor Author

I'm sorry you had to create a new feature branch for this. I could have left it alone.

Not a problem. Maybe it was overkill, but I appreciate feedback when I make further changes beyond what was asked for.

@forevermatt forevermatt merged commit 515de21 into develop May 20, 2024
2 checks passed
@forevermatt forevermatt deleted the feature/revise-error-for-authinit-failures branch May 20, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@jason-jackson jason-jackson jason-jackson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forevermatt @briskt @jason-jackson