Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5.6.0 - Update to PHP 8.3 #176

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Release 5.6.0 - Update to PHP 8.3 #176

wants to merge 6 commits into from

Conversation

jason-jackson
Copy link

Changed

  • Update to php 8.3
  • Upgrade dependencies

PR Checklist

  • Put version number in PR title (e.g. Release x.y.z - Summary of changes)
  • Documentation (README, etc.)
  • Unit tests created or updated
  • Run make composershow

@jason-jackson jason-jackson requested review from a team as code owners January 27, 2025 19:10
@jason-jackson jason-jackson requested review from briskt, forevermatt, mtompset and hobbitronics and removed request for a team January 27, 2025 19:10
briskt
briskt reviewed Jan 28, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 29, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mtompset
mtompset reviewed Feb 5, 2025
View reviewed changes
Dockerfile
FROM silintl/php8:8.1
LABEL maintainer="matt_henderson@sil.org"
FROM silintl/php8:8.3
LABEL maintainer="gtis_itse_support@sil.org"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps "+idp-id-sync" on the user id? Just a thought.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's necessary or even particularly helpful. If anything, it would be +idp so any incoming issues would be tagged with "IDP".

@briskt
Copy link
Contributor

briskt commented Feb 17, 2025

@jason-jackson it looks to me like this can be merged. Is there something holding it back?

mtompset
mtompset reviewed Feb 19, 2025
View reviewed changes
Dockerfile
@@ -1,10 +1,10 @@
FROM silintl/php8:8.1
LABEL maintainer="[email protected]"
FROM silintl/php8:8.3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for the model generation scope and data typing issues with Yii 2.0.52.

@forevermatt forevermatt changed the title Release 5.5.0 - Update to PHP 8.3 Release 5.6.0 - Update to PHP 8.3 Feb 24, 2025
@forevermatt
Copy link
Contributor

I've updated the version number in the title to be 5.6.0 now that there's already a 5.5.0, and you may also want to merge main back into this feature branch before merging this, but if there are no conflicts that's less critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@mtompset mtompset mtompset left review comments

@forevermatt forevermatt forevermatt approved these changes

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/php-devs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jason-jackson @briskt @forevermatt @mtompset