Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 8.0.0-pre.0 - remove LDAP #311

Closed
wants to merge 2 commits into from
Closed

Release 8.0.0-pre.0 - remove LDAP #311

wants to merge 2 commits into from

Conversation

jason-jackson
Copy link
Contributor

Removed

  • Remove LDAP support

PR Checklist

  • Put version number in PR title (e.g. Release x.y.z - Summary of changes)
  • Documentation (README, etc.)
  • Unit tests created or updated
  • Run make composershow

@jason-jackson jason-jackson requested review from a team as code owners February 20, 2025 15:29
@jason-jackson jason-jackson requested review from briskt, forevermatt, mtompset and hobbitronics and removed request for a team February 20, 2025 15:29
hobbitronics
hobbitronics approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. So does removing code count against your contributed lines of code?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@briskt
Copy link
Contributor

briskt commented Feb 21, 2025

Unfortunately, I misled you. We are, in fact, still using LDAP for one IdP. We may be able to remove LDAP soon, but not right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@briskt briskt Awaiting requested review from briskt briskt is a code owner automatically assigned from silinternational/php-devs

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/php-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jason-jackson @briskt @hobbitronics