Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break out ConfigData into Types for DAB / SAB #717

Merged
merged 8 commits into from
Nov 8, 2024
Merged

Break out ConfigData into Types for DAB / SAB #717

merged 8 commits into from
Nov 8, 2024

Conversation

EthanFennell
Copy link
Contributor

No description provided.

@EthanFennell
Broke out ConfigData into AppConfig,
832821f 
ScriptureConfig, and Dictionary Config
chrisvire
chrisvire requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@chrisvire chrisvire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good! There are a few changes I would like you to make.

convert/convertConfig.ts Outdated Show resolved Hide resolved
convert/convertConfig.ts Outdated Show resolved Hide resolved
convert/convertConfig.ts Outdated Show resolved Hide resolved
convert/convertConfig.ts Outdated Show resolved Hide resolved
convert/convertConfig.ts Outdated Show resolved Hide resolved
convert/convertConfig.ts Outdated Show resolved Hide resolved
config/index.d.ts Outdated
family: string;
name?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneeded diff.

config/index.d.ts Outdated
fontStyle: string;
fontWeight: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneeded diff.

convert/convertConfig.ts Outdated Show resolved Hide resolved
convert/convertConfig.ts Outdated Show resolved Hide resolved
chrisvire
chrisvire requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@chrisvire chrisvire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just address my comments and I can approve.

chrisvire
chrisvire approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@chrisvire chrisvire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chrisvire chrisvire merged commit e0255a5 into main Nov 8, 2024
1 check passed
@chrisvire chrisvire deleted the feature/parse-specific-config-types/676 branch November 8, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisvire chrisvire chrisvire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EthanFennell @chrisvire