Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated localizations #313

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Updated localizations #313

wants to merge 4 commits into from

Conversation

tombogle
Copy link
Contributor

@tombogle tombogle commented Feb 27, 2025

This change is Reviewable

@tombogle tombogle self-assigned this Feb 27, 2025
Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 18 files at r1, all commit messages.
Reviewable status: 9 of 18 files reviewed, 1 unresolved discussion (waiting on @tombogle)


a discussion (no related file):
Note that I didn't really review the .xlf changes.


a discussion (no related file):
Looks like this is fixing a bug and improving localizations, but the PR title just talks about improving localizations.
Hm. I see now this is on top of the other PR.

@andrew-polk
Copy link
Contributor

Previously, andrew-polk wrote…

Looks like this is fixing a bug and improving localizations, but the PR title just talks about improving localizations.
Hm. I see now this is on top of the other PR.

I think you can just make the base branch the bug fix branch, and it will automatically get set correctly when the other gets merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants