Changed StandardSubtags.AddLanguage to add the new entry to the Iso3Languages dictionary #1399
+68
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Iso3Languages dictionary instead of rebuilding the whole dictionary Fair bit of additional code cleanup/refactoring
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @tombogle)
SIL.WritingSystems/Subtag.cs line 152 at r1 (raw file):
public static implicit operator string(Subtag subtag) { return subtag == null ? null : subtag.Code;
How about return subtag?.Code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the former inefficient logic that rebuilt the whole dictionary on each add.
Fair bit of additional code cleanup/refactoring
This change is