Remove useless variable assignments #1400
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -47,7 +47,7 @@ | |||
| using (TempFile working = new TempFile(_originalLift)) | |||
| { | |||
| int howManyEntries = 10000; | |||
| Debug.WriteLine("running test using "+howManyEntries.ToString()+" entries"); | |||
| Debug.WriteLine("running test using " + howManyEntries.ToString() + " entries"); | |||
Check notice
Code scanning / CodeQL
Redundant ToString() call Note test
Comment on lines
+72
to
+76
| if (keymanLink.Initialize()) | ||
| { | ||
| if (keymanLink.Keyboards != null && keymanLink.Keyboards.Length > 0) | ||
| return true; | ||
| } |
Check notice
Code scanning / CodeQL
Nested 'if' statements can be combined Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes roughly half of the 80+ "Useless assignment to local variable" code warnings: https://github.com/sillsdev/libpalaso/security/code-scanning?query=is%3Aopen+branch%3Amaster+rule%3Acs%2Fuseless-assignment-to-local
This change is