Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For some breaking changes #634

Merged
merged 3 commits into from
Feb 25, 2025
Merged

For some breaking changes #634

merged 3 commits into from
Feb 25, 2025

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Feb 21, 2025

More to be done in general, but this should fix the breaking changes.


This change is Reviewable

@johnml1135 johnml1135 requested a review from Enkidu93 February 21, 2025 17:56
@johnml1135
Copy link
Collaborator Author

We need to release Machine first.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@johnml1135
Copy link
Collaborator Author

Waiting for Machine 3.6.0 to be released.

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@Enkidu93
Copy link
Collaborator

What is blocking machine's release, @johnml1135? This is still a hindrance for the WA PR getting through.

@Enkidu93
Copy link
Collaborator

What is blocking machine's release, @johnml1135? This is still a hindrance for the WA PR getting through.

I guess for now, I'll just put in minimal changes to get the PR to build.

@ddaspit
Copy link
Contributor

ddaspit commented Feb 24, 2025

The new version of Machine should be published on NuGet now.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.18%. Comparing base (e024561) to head (f27fa7e).

Files with missing lines Patch % Lines
...ed.Tests/Services/ScriptureDataFileServiceTests.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #634   +/-   ##
=======================================
  Coverage   64.18%   64.18%           
=======================================
  Files         281      281           
  Lines       14210    14210           
  Branches     1847     1847           
=======================================
  Hits         9121     9121           
  Misses       4427     4427           
  Partials      662      662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135 johnml1135 merged commit 739aa19 into main Feb 25, 2025
3 checks passed
@johnml1135 johnml1135 deleted the fixes_for_machine_updates branch February 25, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants