-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For some breaking changes #634
Conversation
We need to release Machine first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
Waiting for Machine 3.6.0 to be released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @johnml1135)
What is blocking machine's release, @johnml1135? This is still a hindrance for the WA PR getting through. |
I guess for now, I'll just put in minimal changes to get the PR to build. |
The new version of Machine should be published on NuGet now. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
=======================================
Coverage 64.18% 64.18%
=======================================
Files 281 281
Lines 14210 14210
Branches 1847 1847
=======================================
Hits 9121 9121
Misses 4427 4427
Partials 662 662 ☔ View full report in Codecov by Sentry. |
More to be done in general, but this should fix the breaking changes.
This change is