Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run installer #104

Merged
merged 23 commits into from
Aug 30, 2024
Merged

Run installer #104

merged 23 commits into from
Aug 30, 2024

Conversation

josephmyers
Copy link
Collaborator

@josephmyers josephmyers commented Aug 15, 2024

This change is Reviewable

This fixes some architecture build warnings
The latest uses v10 of libpalaso, where the explicit ref's in Installer.wxs for WeSay need 9.
@josephmyers josephmyers marked this pull request as ready for review August 30, 2024 02:42
@josephmyers
Copy link
Collaborator Author

https://github.com/sillsdev/wesay/actions/runs/10612871182

This is the most recent Installer CI run, before I restored the original GHA run settings. The artifacts are at the bottom of the page.

Copy link
Contributor

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me! I will test out the installer now

@megahirt
Copy link
Contributor

Installer works, so we can merge this!

@megahirt megahirt merged commit 6346eaf into develop Aug 30, 2024
2 of 3 checks passed
@megahirt megahirt deleted the installer branch August 30, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants