Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Use attributes for DataProviders #11581

Merged
merged 1 commit into from
Jan 29, 2025
Merged

MNT Use attributes for DataProviders #11581

merged 1 commit into from
Jan 29, 2025

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jan 28, 2025 •
edited
Loading

@emteknetnz emteknetnz mentioned this pull request Jan 28, 2025
Closed
@emteknetnz emteknetnz force-pushed the pulls/6.0/broken-builds branch from 86cac75 to ea81faf Compare January 28, 2025 05:15
@emteknetnz emteknetnz marked this pull request as ready for review January 28, 2025 22:20
GuySartorelli
GuySartorelli approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 0f6250d into silverstripe:6.0 Jan 29, 2025
13 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6.0/broken-builds branch January 29, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli