Port to Python 3.x #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim0nx
requested changes
Feb 5, 2017
There was a problem hiding this comment.
Hi,
Thanks for your PR.
"Most people", maybe but not all :-)
I would appreciate it if you could just add few small changes to your PR to make it PY2 and PY3 compatible.
In addition to what I posted in the review, also add this to tsl2561.py right below the header:
from future import absolute_import, division, print_function, unicode_literals
Thanks
| @@ -7,7 +7,7 @@ Python library for TSL2561 | |||
|
|
|||
| Requirements | |||
| ------------ | |||
| - python 2.7.x | |||
There was a problem hiding this comment.
just add py3 to the list, don't remove py2 completely
tsl2561/tsl2561.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env python | |||
| #!/usr/bin/python3 | |||
There was a problem hiding this comment.
If py3 is your default, the original header will still run it with py3, so don't force python3 here
|
Agreed. I made the changes you suggested. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think by now, most people are using Python3.x. For this driver, only a few changes were necessary.