-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: assumeCorrectReference option resolves #2715 #2733
feat: assumeCorrectReference option resolves #2715 #2733
Conversation
assumeCorrectReference option added assume the correct reference of the dart code in views, when resolver fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of this option since it essentially bypasses the analyzer, but I think we can have it for this specific use-cases since this used to work.
Removed residual code and comments. Commented and explained staticSource Removed modularBuild and tested test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
assumeCorrectReference option added
assume the correct reference of the dart code in views, when the resolver fails.
Description
This will allow the ability to use drift tables and dart views. The resolver cannot resolve references of the tables as it doesn't have any context of it yet.
But by coding ahead we know what those references are thus we can use type-safe views.
Example
build.yaml
descriptors.drift
string_table.drift
descriptor_view.dart