-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new listr function with add capability #144
base: master
Are you sure you want to change the base?
feat: add new listr function with add capability #144
Conversation
BREAKING CHANGE: It is now possible to give a folder as file argument e.g.: md2pdf $(pwd) This works recursive. The watcher will listen for all add and change events in all subfolders, but only for markdown files. For compatibility, a legacy function is kept alive, to handle multiple input paths, like ./**/*.md, so the old cli app works like before.
Hi, Refactored on the way a few things. Would be nice, if we can pull this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this! I've had a quick look, and it's a lot of changes overall... finding it a bit hard to follow through. Would have been nice if you could have split it into separate commits for the individual changes so it would be easier to understand and reason about each change 🤓
Anyway, one thing I would like to propose is to allow setting a folder with a -r
/--recursive
flag instead, so maybe this could get away as a non-breaking change (:
But not sure I would go ahead with this PR as-is, e.g. I find the "convert factory" part a bit too abstract.
Thanks for the feedback. I implemented the convertFactory for that it is not more necessary to push all the configs and args around. If you are willing to merge it, if I develop it further to your coding style, I will do. Just tell me. Dunno if its necessary to add that -r flag. But I had the idea, that a user could give a folder, and set the |
Pushed a commit where convertFactory is removed. I would need to dig deeper in CLI flags, to get to know how to implement the -r flag. |
BREAKING CHANGE: It is now possible to give a folder as file argument e.g.: md2pdf $(pwd)
This works recursive. The watcher will listen for all add and change events in all subfolders, but only for markdown files.
For compatibility, a legacy function is kept alive, to handle multiple input paths, like ./**/*.md, so the old cli app works like before.