Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow reading RHACK_DIR from .cargo/config.toml files. #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

seivan
Copy link

@seivan seivan commented Jul 18, 2024

Search order:

  1. $RHACK_DIR
  2. .cargo/config.toml
  3. $CARGO_HOME/config.toml

Order: `RHACK_DIR` env variable, local `.cargo/config.toml`, `$CARGO_HOME/config.toml`.
@simonsan
Copy link
Owner

simonsan commented Nov 4, 2024

Will review later today, thank you for the PR, and sorry for the delay. 👍🏽

@seivan
Copy link
Author

seivan commented Nov 29, 2024

@simonsan Any updates?

@simonsan
Copy link
Owner

@simonsan Any updates?

Wtf, sorry I totally forgot. Will do it in the evening!

@simonsan
Copy link
Owner

Ok, I was looking into it. Could you say a bit about the value reading the .cargo/config.toml gives? My intention was to migrate it to abscissa and have a usual configuration within a directory according to directories project-dir. So I'm not entirely sure about this, but happy to be explained what it is making better.

@seivan
Copy link
Author

seivan commented Nov 29, 2024

Ok, I was looking into it. Could you say a bit about the value reading the .cargo/config.toml gives?

It reads a path to store the "hacks". This makes sure you can define it in your projects Cargo.toml or use a global config like $CARGO_HOME.

Right now it puts all of them in a single place. This lets you have a per project setting if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants