Fix issue 36 #312
Merged
Fix issue 36 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reorder arguments to make_stft_objects so that units is an optional kwarg - replace a use of config with tfk.config - remove duplicate definition of run_obj
- instead of using a flat dict with metadata, use nested dict
- first layer denotes the channel type ("electric" or "magnetic")
- also modified test_compare so that it is easier to export a csv
- upsample_factor removed as arg, deduced from run.sample_rate
- if a station that is not in the run summary is requested, the output to screen did not make it clear that this was the problem. - added an explicit check for an empty df after restrict_to_station_list in kernel_dataset. - if df is empty, log an informative message and raise ValueError
- also remove some unused imports, add a few notes - remove unused i_dec_level argument from get_band_for_tf_estimate
- switch order of commented debugging statements for easier use
- remove nT <--> T handling from inventory_review in sandbox - replace with triage_mt_units_magnetic_field - make triage_units a list, not a string, that can handle electrics an magnetics - make MT2SI_MAGNETIC_FIELD_FILTER
- calibration should not coompensate for decimation AAF by default
- decorate with @path_or_mth5_object, tidy up doc strings
- delete add_filters method from aurora, this is now in mth5 - minor tidying, alphabetize imports, etc.
- also rename some functions more appropriately - tested that jackknife jj84 coh-sorting works on synthetic
- the integer decimation level was not needed - this propagates to some other functions, that now take dec_level_cfg instead of config - only logic change was tfk validator now drops ref channels if no RR station
- add a test covering typecheck on time_period - fix bug (isinstance args were permuted in fourier_coefficients.py)
- removed an unneeded argument station_id from make_stft_objects - also, removed some Musgraves triage logic and put in sandbox/triage_metadata.py - this makes these lines testable in a much less complex way - added a test for the new function (albeit in sandbox)
- this method is still slow, but runs. - next step is to vectorize it
- was using a for loop, in variable partial_coh - in this commit is shown an alternative way that uses linear algebra approach - should be faster as it is vectorized. - next commit will remove the old way
- in prep for doi relase, - updated branches of mth5,mth_metadata to mains - pretty up some logging messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.