Joss #347
Merged
Joss #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update workflow figure
- put a minimal description and links to the more detailed simpeg pages
- was incorrectly called figure_path, not figures_path - never noticed before because it was a kwarg
- now points to joss branch
Update docs
Fix issue 337 Based on discussion in second JOSS review, this is ready to merge
add doc for synthetic data processing notebook
address issue #333
These were suppresed during manuscript development to conserve energy. We are re-enabling them so that the `joss` release can be shown to pass tests with the current mt_metadata, and mth5 releases. The tests.yml pins mt_metadata to 0.3.7, and mth5 to 0.4.4 - also updated path to ipynb moved from example to tutorial in yml - (and updated the filename)
- minor changes to accomodate mt_metadata 0.3.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much doc was added during the JOSS review process -- this should merge into patches before patches goes to main