Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding of download colored SVGs #342

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

LitoMore
Copy link
Member

Related to this discussion: https://news.ycombinator.com/item?id=41598301

We should encode the image string for the data URL.

@LitoMore LitoMore requested a review from mondeja September 24, 2024 13:52
@LitoMore LitoMore added the bug Something isn't working label Sep 24, 2024
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we're expecting the characters to still be encoded in the downloaded file? If so, spot on.
image

@LitoMore
Copy link
Member Author

@adamrusted It's the expected behavior. Please check our source files.

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mondeja mondeja merged commit 2f9a48f into simple-icons:master Sep 24, 2024
3 checks passed
@LitoMore LitoMore deleted the fix-download-colored-svg branch September 24, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants