-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #90 (and hopefully #91) #93
Conversation
I hope this works. But I cannot test this, since I don't understand the babel stuff. How do I make a version to test this with? |
Thanks! |
@gruijter |
thanx. I did build and got a lib/. But when testing I get
|
I'm getting the same error as @gruijter:
|
I've fixed the issues, and published a new version to npm. The codepath using tokens wasn't tested, I should review the code better before I quickly merge it when I wake up lol. Sadly I don't have a Magister account so I can only read the code and guess if it's correct or not. |
@lieuwex Thx for your help! But unfortunately another error appears now:
|
Oh shit, completere my fault to open a pull before testing fully. Sorry @lieuwex |
I can confirm that with alpha4 #91 is still an issue. |
I can't reproduce #91 so I can't really test if this fixes it. It does fix #90 tho