Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #90 (and hopefully #91) #93

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Fix for #90 (and hopefully #91) #93

merged 1 commit into from
Nov 7, 2018

Conversation

idiidk
Copy link
Collaborator

@idiidk idiidk commented Nov 6, 2018

I can't reproduce #91 so I can't really test if this fixes it. It does fix #90 tho

I can't reproduce #91 so I can't really test if this fixes it. It does fix #90.
@gruijter
Copy link

gruijter commented Nov 7, 2018

I hope this works. But I cannot test this, since I don't understand the babel stuff. How do I make a version to test this with?

@lieuwex
Copy link
Member

lieuwex commented Nov 7, 2018

Thanks!

@lieuwex lieuwex merged commit 033a602 into simplyGits:master Nov 7, 2018
@lieuwex
Copy link
Member

lieuwex commented Nov 7, 2018

@gruijter npm install && npm run build in the Magisterjs folder should build the needed filed in lib/.

@gruijter
Copy link

gruijter commented Nov 7, 2018

thanx. I did build and got a lib/. But when testing I get

TypeError: setToken(...).then is not a function
    at \node_modules\magister.js\lib\magister.js:522:36

@netlob
Copy link
Contributor

netlob commented Nov 7, 2018

I'm getting the same error as @gruijter:

something went wrong: TypeError: setToken(...).then is not a function
    at \node_modules\magister.js\lib\magister.js:522:36
    at Generator.next (<anonymous>)
    at step (\node_modules\magister.js\lib\magister.js:132:191)
    at \node_modules\magister.js\lib\magister.js:132:437
    at new Promise (<anonymous>)
    at \node_modules\magister.js\lib\magister.js:132:99
    at Magister.login (\node_modules\magister.js\lib\magister.js:589:5)
    at Promise.resolve.then (\node_modules\magister.js\lib\magister.js:624:28)
    at process._tickCallback (internal/process/next_tick.js:68:7)

@lieuwex
Copy link
Member

lieuwex commented Nov 7, 2018

I've fixed the issues, and published a new version to npm. The codepath using tokens wasn't tested, I should review the code better before I quickly merge it when I wake up lol. Sadly I don't have a Magister account so I can only read the code and guess if it's correct or not.

@gruijter
Copy link

gruijter commented Nov 7, 2018

@lieuwex Thx for your help! But unfortunately another error appears now:

TypeError: Cannot use 'in' operator to search for 'SecondsLeft' in SecurityToken Expired
    at promise.then.then.res (\node_modules\magister.js\lib\http.js:151:22)

@lieuwex
Copy link
Member

lieuwex commented Nov 7, 2018

@gruijter huh funny, didn't expect that to happen. I've opened #94 because I have to first fix another issue before I can fix this.

@idiidk
Copy link
Collaborator Author

idiidk commented Nov 7, 2018

Oh shit, completere my fault to open a pull before testing fully. Sorry @lieuwex

@gruijter
Copy link

gruijter commented Nov 8, 2018

When using username/password #91 is not solved. Using the token results in #94.

@gruijter
Copy link

I can confirm that with alpha4 #91 is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When logging in with token, no profileinfo is given back
4 participants