Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.2.2 #27

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Release v0.2.2 #27

merged 1 commit into from
Oct 16, 2024

Conversation

gventuri
Copy link
Contributor

@gventuri gventuri commented Oct 16, 2024

  • chore[processes]: wait for process preprocessing before comple tely executing

  • fix[process_queue]: code improvements

Summary by CodeRabbit

  • New Features

    • Introduced new linting commands for code quality maintenance.
    • Added a ProcessScheduler class to manage and execute processes.
    • Enhanced process management by refining selection criteria for processing steps.
    • Added a method to retrieve process steps based on specific statuses.
  • Bug Fixes

    • Improved handling of process states to ensure accurate completion status.
  • Tests

    • Added unit tests for the ProcessScheduler class to validate its functionality and behavior.
  • Chores

    • Updated project dependencies to include the schedule package.

…tely executing (#26)

* chore[processes]: wait for process preprocessing before comple
tely executing

* fix[process_queue]: code improvements
Copy link
Contributor

coderabbitai bot commented Oct 16, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several enhancements across multiple files in the backend. It adds two new make targets for linting in the Makefile, implements a ProcessScheduler class for managing process execution in process_scheduler.py, and refines process handling in process_queue.py. A new method for retrieving process steps with asset content is added to process_repository.py, and a dependency for scheduling is introduced in pyproject.toml. Additionally, comprehensive unit tests for the ProcessScheduler are provided in test_process_scheduler.py.

Changes

File Path Change Summary
backend/Makefile Added new targets: lint (for linting checks) and lint-fix (for auto-fixing linting issues).
backend/app/processing/process_queue.py Updated submit_process method signature; added ProcessScheduler instance; refined process handling logic.
backend/app/processing/process_scheduler.py Introduced ProcessScheduler class with methods for managing process execution and scheduling.
backend/app/repositories/process_repository.py Added get_process_steps_with_asset_content method for retrieving process steps by status.
backend/pyproject.toml Added dependency: schedule = "^1.2.2" for scheduling functionality.
backend/tests/processing/test_process_scheduler.py Introduced unit tests for ProcessScheduler covering various functionalities and behaviors.

Possibly related PRs

🐰 In the garden where rabbits play,
New tools for linting come out to stay.
A scheduler hops, managing tasks with care,
While tests ensure nothing's rare.
With each little change, our code shines bright,
A bouncy delight, in the soft moonlight! 🌙✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gventuri gventuri merged commit b82c6e3 into main Oct 16, 2024
4 of 5 checks passed
@gventuri gventuri deleted the release/v0.2.2 branch October 16, 2024 18:17
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.75862% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.09%. Comparing base (2d0254f) to head (0b9956c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/app/processing/process_queue.py 33.33% 8 Missing ⚠️
backend/app/processing/process_scheduler.py 97.67% 1 Missing ⚠️
backend/app/repositories/process_repository.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   53.11%   54.09%   +0.98%     
==========================================
  Files          36       37       +1     
  Lines        1751     1806      +55     
==========================================
+ Hits          930      977      +47     
- Misses        821      829       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants