DEVEXP-563: Add SMS 'Getting Started' code #4
Conversation
asein-sinch
requested review from
JPPortier,
krogers0607,
Dovchik and
650elx
as code owners
| @@ -0,0 +1,5 @@ | |||
| export const validateSignature = (req, res, next) => { | |||
| console.log('Validating SMS event signature.'); | |||
| // Do nothing as this feature is not supported yet. | |||
There was a problem hiding this comment.
If it's not supported yet, maybe it's better to skip it?
There was a problem hiding this comment.
Or rather not.
The Node.js SDK doesn't support the validation of the signature headers but the customer that will use this guide may have the feature activated on their account. If they want to perform the validation, the architecture is ready to do so.
Thus, I prefer to keep it this way.
| SINCH_PROJECT_ID = <Your Sinch Project ID> | ||
| SINCH_KEY_ID = <Your Sinch Key ID> | ||
| SINCH_KEY_SECRET = <Your Sinch Key Secret> | ||
| SMS_REGION = us |
There was a problem hiding this comment.
Same comment as fro server template: is us is not yet the default value ?
| keySecret: process.env.SINCH_KEY_SECRET, | ||
| servicePlanId: process.env.SINCH_SERVICE_PLAN_ID, | ||
| apiToken: process.env.SINCH_API_TOKEN, | ||
| smsRegion: process.env.SMS_REGION || SmsRegion.UNITED_STATES, |
There was a problem hiding this comment.
Seems SinchCLient is already setting it as a default value: https://github.com/sinch/sinch-sdk-node/blob/main/packages/sms/src/rest/v1/sms-domain-api.ts#L83
And we are setting again the default usvalue at config file level and also here
Sure: the us will be a very default value 😄
| @@ -0,0 +1,5 @@ | |||
| export const validateSignature = (req, res, next) => { | |||
| console.log('Validating SMS event signature.'); | |||
| // Do nothing as this feature is not supported yet. | |||
No description provided.